Creating Resource to add onAnimationTrigger back to 1.2

#1 Think this is what you are looking for

A related resource that might be interesting aswell:
http://www.garagegames.com/community/resources/view/21654

#2 this did not come up in my searches... Interesting... I'll check it out.

Thanks.

#3 I see why I might need the other resource. I wonder if the trigger can send the name back with the onAnimationTrigger_Callback. I noticed all the call backs are scripted differently now. I wonder if it was part of the speed enhancements they have done.

Hmm I'm going to see if i can play with this and adapt it to their new methods as well. Thanks.

#4 AFAIK the changes are made for documentation purposes, it is easier to read what the code does now.
You can read about it here:
At comment 354
Edit: the 4th post is about callbacks

#5 Yeah, you definitely can pass the animation name at the same time. I (re)implemented this stuff a while ago, and keep forgetting that resource existed to post that little tidbit there.

Your callback declaration would be something like this:

DECLARE_CALLBACK( void, onAnimationTrigger, ( ShapeBase* obj, S32 state, const char* animName ) );

And the implementation:

IMPLEMENT_CALLBACK( ShapeBaseData, onAnimationTrigger, void, ( ShapeBase* obj, S32 state, const char* animName ), ( obj, state, animName ), "");

So then the trigger loop would look like this:

if (mShapeInstance && !isGhost()) {  
			for (U32 i = 1; i < 32; i++) {  
				if (mShapeInstance->getTriggerState(i)) {  
					const char* animName = st.thread->getSequenceName();
					mDataBlock->onAnimationTrigger_callback(this,i,animName);  
				}  
			}  
		 }

Be aware that action animations don't work with this too well, and you might have to implement a version specific to them.

#6 I didn't get any callbacks to fire with this resource (updated it to use new callbacks as well)...but I think it's because of using dts models and this issue: link

#7 Is the issue of adding triggers to sequences broken with the UI, or is it that triggers simply don't work?

At the risk of self serving promotion: DSQTweaker edits DSQ files to include triggers....

#8 @Rex,
That is good to know. If I get 3rd party resources that are in DSQ then I know there is a tool to add triggers. Thanks.

#9 I have added this and I'm using the shape editor to add triggers and there's an echo in the call back but it does not fire.

#10 I got this to work, i'll dig out my changes and post in a little while if you need them

#11 yes please

#12 Sorry forgot :/

Anyhow it looks like I just used Richard Marrevee's resource (this first link Lucas posted)
but changed a couple of things

I didn't add in the scriptThis function but used getIdString() instead
and added in an extra sequence name parameter.

heres the modified part of advanceThreads

// << Jonajoint Added -> animation Trigger Resource (Richard Marrevee)
		if (mShapeInstance && !isGhost()) {  
          for (U32 i = 1; i < 32; i++) {  
              if (mShapeInstance->getTriggerState(i)) {  
                 char slot[3];  
                 dSprintf(slot,sizeof(slot),"%d",i);  
                 Con::executef(mDataBlock,"onAnimationTrigger",this->getIdString(),slot,st.thread->getSequenceName());  
              }  
          }  
		}

I've been meaning to convert it to IMPLEMENT_CALLBACK type thingy (what ever the technical name is i've no idea :p)
but this seems to work fine.

edit:-
the script function for the above is this, for a DataBlock called Catapult...
function Catapult::onAnimationTrigger(%this, %obj, %trigger, %seqName)