[BUG] Min/Max Slope painting feature in Terrain Texture Painter (with fix) - RESOLVED

#1 I am using 1.0.1 and it works for me, with one caveat. you cant type in a number in the min/max boxes you have to use the sliders to set your numbers or it wont take

its that way with 1.1b1 too

#2 Yeah, finally figured that out... I detest the sliders though ;)

#3 Quick/Simple (although not final) fix for setMinSlope

tools/worldEditor/gui/TerrainPainterToolbar.ed.gui
At line# 268 where it says:

Command = "setMinSlope( $ThisControl.getText() );";

make it say:

Command = "setTerrainEditorMinSlope( $ThisControl.getText() );";

#4 Quick/Simple (although not final) fix for setMinSlope

tools/worldEditor/gui/TerrainPainterToolbar.ed.gui
At line# 467 where it says:

%val = ETerrainEditor.setSlopeLimitSlopeMaxAngle( %value );

make it say:

%val = ETerrainEditor.setSlopeLimitMaxAngle( %value );

#5 I'll check this against 1.1 Beta 2 to make sure it isn't still a bug.

#6 Hehe, it still is -- I noticed the problem while using the current repo ;)

#7 Yeah, I was just checking it and saw it was. Writing a ticket for it now.

Logged as THREED-978.

#8 @Michael: I couldn't get your fix working on my machine, still got wonky results when trying to set the values by hand. I implemented and checked in a new fix that both gives expected results from text entry and regulates the slider behavior. I'm running very late to take a test right now, so I'll post the actual changes first thing in the morning when I get to my desk.

#9 At the point in time I had posted this I was getting weirdness with the text entry aspect myself - a proper fix would be to add a validateSlopeAngle method to the Terrain Painter plugin. Seems this feature in the editor was missing them when compared to other editor functionality.

#10 Okay, sorry about that. I've got it all fixed up and working properly now. Damn school for making me run off at odd times :P Anyway, for all those interested here's the fix:

First off revert any changes you may have implemented earlier.

Now, in your worldEditor/gui/TerrainPainterToolbar.ed.gui file, make the following changes.

Starting with line #256:

new GuiTextEditCtrl() {
            internalName = "SlopeMinAngle";
            canSaveDynamicFields = "0";
            isContainer = "0";
            Profile = "GuiNumericDropSliderTextProfile";
            HorizSizing = "right";
            VertSizing = "bottom";
            Position = "104 2";
            Extent = "51 18";
            MinExtent = "8 2";
            canSave = "1";
            Visible = "1";
            validate = "TerrainPainterPlugin.validateSlopeMinAngle();";//add this line
            Command = "ETerrainEditor.setSlopeLimitMinAngle( $ThisControl.getText() );";//change this line

Line #317:

new GuiTextEditCtrl() {
            internalName = "SlopeMaxAngle";
            canSaveDynamicFields = "0";
            isContainer = "0";
            Profile = "GuiNumericDropSliderTextProfile";
            HorizSizing = "right";
            VertSizing = "bottom";
            Position = "190 2";
            Extent = "51 18";
            MinExtent = "8 2";
            canSave = "1";
            Visible = "1";
            validate = "TerrainPainterPlugin.validateSlopeMaxAngle();";//add this line
            Command = "ETerrainEditor.setSlopeLimitMaxAngle( $ThisControl.getText() );";//change this line

Line#513

new GuiSliderCtrl() {
      canSaveDynamicFields = "0";
      internalName = "slider";
      isContainer = "0";
      Profile = "GuiSliderBoxProfile";
      HorizSizing = "right";
      VertSizing = "bottom";
      position = firstWord(PaintBrushSlopeControl.position) + firstWord(EWTerrainPainterToolbar.position)+firstWord(PaintBrushSlopeControl->SlopeMinAngle.position) - 40 SPC
         (getWord(PaintBrushSlopeControl, 1)) + 25;
      Extent = "112 20";
      MinExtent = "8 2";
      canSave = "1";
      Visible = "1";
      AltCommand = "PaintBrushSlopeControl-->SlopeMinAngle.setValue(mFloatLength( ($ThisControl.getValue()), 1 )); ETerrainEditor.setSlopeLimitMinAngle(mFloatLength( ($ThisControl.getValue()), 1 ));TerrainPainterPlugin.validateSlopeMinAngle();";//change this line

new GuiSliderCtrl() {
      canSaveDynamicFields = "0";
      internalName = "slider";
      isContainer = "0";
      Profile = "GuiSliderBoxProfile";
      HorizSizing = "right";
      VertSizing = "bottom";
      position = firstWord(PaintBrushSlopeControl.position) + firstWord(EWTerrainPainterToolbar.position)+firstWord(PaintBrushSlopeControl->SlopeMaxAngle.position) - 40 SPC
         (getWord(PaintBrushSlopeControl, 1)) + 25;
      Extent = "112 20";
      MinExtent = "8 2";
      canSave = "1";
      Visible = "1";
      AltCommand = "PaintBrushSlopeControl-->SlopeMaxAngle.setValue(mFloatLength( ($ThisControl.getValue()), 1 )); ETerrainEditor.setSlopeLimitMaxAngle(mFloatLength( ($ThisControl.getValue()), 1 ));TerrainPainterPlugin.validateSlopeMaxAngle();";//change this line

Now in tools/worldEditor/scripts/Editor.Gui.ed.cs:
Line #1203 add the following functions.

function TerrainPainterPlugin::validateBrushSize( %this )
{
   %val = $ThisControl.getText();
   if(%val < 1)
      $ThisControl.setValue(1);
   else if(%val > 40)
      $ThisControl.setValue(40);
}



//BEGIN ADDING NEW CODE
function TerrainPainterPlugin::validateSlopeMaxAngle( %this )
{
   %maxval = ETerrainEditor.getSlopeLimitMaxAngle();
   PaintBrushSlopeControl-->SlopeMaxAngle.setText(%maxval); 
}

function TerrainPainterPlugin::validateSlopeMinAngle( %this )
{
   %minval = ETerrainEditor.getSlopeLimitMinAngle();
   PaintBrushSlopeControl-->SlopeMinAngle.setText(%minval);  
}
//END ADDING NEW CODE

Those changes should get the slider and text fields correctly working when using the terrain painter tool. Let me know if there any any problems or something I may have left out and I'll look into it right away.

#11 Yeah, that's the fix I should've taken the time to do. Good to see it was pretty much as I expected to get the text-entry fully working.

#12 Confirmed as Fixed in 1.1 Beta2