Game Development Community

"Brightness" value is not working with the ScatterSky - RESOLVED

by Stadi Thompson · in Torque 3D Professional · 11/19/2009 (8:18 pm) · 13 replies

The "Brightness" value is not working with the ScatterSky, can anyone else confirm this.

#1
11/19/2009 (9:31 pm)
Nah, working for me. I'm on a has to check GTS250. Works fine here.

[edit]
Disregard
Oopsidoodle - see below
#2
11/19/2009 (10:18 pm)
hmm, i have the same card, the sun works fine, just not the scattersky.
#3
11/19/2009 (11:03 pm)
I can confirm this.
#4
11/19/2009 (11:03 pm)
Doesn't work for me either. Scattersky's SkyBrightness works, but not Brightness.
#5
11/19/2009 (11:07 pm)
Doh!
I was using skyBrightness and not Brightness.

*stares embarrassingly at feet*

Nope, I can't brightness to work.
#6
11/19/2009 (11:30 pm)
Line 195 of scatterSky.cpp should be:

mLight->setBrightness( brightness * mBrightness );

Changing it back to that made it work for me. Just a suggestion, as the sun gets brighter, shadows should get darker no?
#7
11/19/2009 (11:37 pm)
shadows get dark by adjusting the ambient scale, thanks for the fix :)
#8
11/22/2009 (1:39 pm)
Quote: Adam Said:
Changing it back to that made it work for me. Just a suggestion, as the sun gets brighter, shadows should get darker no?


That would be a function of camera or Eye exposure. It is an optical illusion. The do not get darker. Actually, They do get lighter but not as much as the area around them that is lit by the sun. So basically what you see is that the shadow is not getting darker but the difference in visible light level is increasing between the two areas.


#9
11/22/2009 (2:17 pm)
I would have thought that if the sun gets brighter, the shadows would get paler and more diffused, because of the raised levels of ambient light?
havent noticed, must look at my shadow tomorrow
#10
11/23/2009 (10:58 am)
Quote: I would have thought that if the sun gets brighter, the shadows would get paler and more diffused, because of the raised levels of ambient light?
havent noticed, must look at my shadow tomorrow

That is correct. The shadow does get brighter due the bounced or "ambient" Light. But the level of brightness does not increase at the same rate as an area exposed to the increasing direct light. So both are increasing, But not at the same rate so the difference increases and thus give the illusion that the shadows get darker. This illusion is created as a function of exposure. Whether it is you eye or a camera. As the light in the directly lit area increases the iris of your eye "or camera" closes as to not over expose the image. When This happens There is not enough light getting in from the shadow areas and thus the have the appearance of getting darker.

On a camera you can force the iris open and thus get the areas in the shadows. HDRI imagery is used to overcome this and get the full exposure into a single image. By taking the image at multiple exposures and combining them together. But really that is a whole different topic.
#11
11/28/2009 (4:25 pm)
Checked in this change, thanks guys.
#12
06/13/2010 (7:03 pm)
Logged as TQA-363.
#13
08/02/2010 (5:13 pm)
Fixed in 1.1 Beta 2