Camera Orbitmode Camera/Player Independant Rotate (TGE 1.3)

Changes:
- Player now changes facing when walking left/right in orbit mode, but the player will strafe normally in all other camera modes.
- moving the mouse around rotates the camera around the player in orbit mode.
- Made a new function called setCamView to centralize the various advCamera.setBlahModes which is called with setCamView(%this,'orbit(etc)');

I removed a line from advanced camera.cc (to prevent console spam) but the rest is done in script.

The camera orbits the player rather sluggishly and very choppy. I think it may be that it is constantly sending serverCmds to the server but I am not sure, nevertheless I am probably going to modify the camera networking code next because I don't think the server really needs to know anything about the cam except maybe check every once in a while that it is still on target and has not escaped its limits (cheat detection).

**** Disclaimer ***** I am mainly an artist and not a coder. This is my first little bit of code and I thought I would contribute it. Hopefully somebody can make some use of it. It's pretty sloppy and could no doubt be heavily improved on, so use at your own risk, I havent tested it much, and might have left some bits out of the snippet.

That being said, here it is:

First, I implemented Cory Osborn and Thomas "Man of Ice" Lund's Advanced Camera snippet found here.

I wanted the player to turn as he moved left and right in orbit mode, so in default.bind.cs I added this:

function moveleft(%val)
{
   $mvLeftAction = %val * $movementSpeed;
   if ($OrbitModeSet==true)
      $mvYawRightSpeed = %val ? $Pref::Input::KeyboardTurnSpeed : 0;
}

function moveright(%val)
{
   $mvRightAction = %val * $movementSpeed;
   if ($OrbitModeSet==true)
      $mvYawLeftSpeed = %val ? $Pref::Input::KeyboardTurnSpeed : 0;
}

I wanted strafes to be normal in first-person mode so in function toggleFirstPerson I changed this:

function toggleFirstPerson(%val)
{
   if (%val)
   {
      $firstPerson = !$firstPerson;
   }
   
}

to this:

function toggleFirstPerson(%val)
{
   if (%val)
   {
      $firstPerson = !$firstPerson;
   }
   
    if ($pref::Camview =="orbit")
  {
  if ($firstPerson)
     $OrbitModeSet=false;
     else
     $OrbitModeSet=true;
     }
}

and this:

function yaw(%val)
{
   $mvYaw += getMouseAdjustAmount(%val);

}
function pitch(%val)
{
 $mvPitch += getMouseAdjustAmount(%val);
}

to this:

function pitch(%val)
{

$mvPitch += getMouseAdjustAmount(%val);
rotateCameraVertical(%val);

}

function yaw(%val)
{
if ($OrbitModeSet==true)
{
   rotateCameraHorizontal(%val);

  }
  else $mvYaw += getMouseAdjustAmount(%val);
  rotateCameraHorizontal(%val);
}

I wanted a function to handle the changing of the modes so I could refer to it from other parts of the script (such as adding a toggle)so in game.cs (end of function GameConnection::createPlayer) I replaced this:

// We set the camera system to run in 3rd person mode around the %player
  %this.advCamera.setPlayerObject(%player);
  %this.advCamera.setThirdPersonMode();
  %this.advCamera.setFollowTerrainMode(false);
  %this.setCameraObject(%this.advCamera);

with this:

setCamView(%this,'orbit');

Here's the function I created, I had to use a bunch of "if's" because I couldnt get switches to work for some reason. In camera.cs I added this:

function setCamView(%this, %mode, %followterrain)
{

 if (%followterrain)
 %this.advCamera.setFollowTerrainMode(true);
 $OrbitModeSet=false;

// We set the camera system to run in 3rd person mode around the %player
  %this.advCamera.setPlayerObject(%this.player);
//  The offset values in the datablock can be changed for the camera object via script using
//      get/setLookAtOffset();
//      get/setThirdPersonOffset();
//      get/setGodViewOffset();

if (%mode=="track")
      %this.advCamera.setTrackMode();
      
if (%mode=="third")
      %this.advCamera.setThirdPersonMode();
      
if (%mode=="target")
      //  Need a setTargetObject()  here
      // and setCameraPosition(Point3F pos) for stationary camera
      %this.advCamera.setThirdPersonTargetMode();
      
if (%mode=="god")
      %this.advCamera.setGodViewMode();
      
if (%mode=="orbit")
{
      $OrbitModeSet=true;
      %this.advCamera.setOrbitMode();
      
      }
// Set the pref for later reference
$pref::Camview  = %mode;
%this.setCameraObject(%this.advCamera);

}

I didn't need these controls anymore since they are taken care of in moveleft/right and pitch/yaw so in config.cs I commented out these lines like this:

//moveMap.bind(keyboard, "g", AvatarCamRotateClockwise);
//moveMap.bind(keyboard, "j", AvatarCamRotateCounterClockwise);
//moveMap.bind(keyboard, "h", AvatarCamPitchDown);
//moveMap.bind(keyboard, "y", AvatarCamPitchUp);

To speed up the rate at which the camera rotates around the player i changed orbitChangeAngle in datablock AdvancedCameraData from 5 to 10.

I commented out this line (from the sourcecode in advancedcamera.cc) to prevent console spam:

Con::printf("At processPlayerInput: direction is %i", direction);

Well that's it. I hope I didn't leave anything out. Feel free to abuse it, improve it and otherwise exploit it however you wish :)