TGEA 1.7.1 - DDS images that are non-pow2 render incorrectly.

#1 Well... 512x512 is square and pow2. 800x600 is non-square and non-pow2. Try 512x256 for non-square pow2 and 800x800 for square non-pow2. Then we can say if it's non-square, non-pow2, or non-square and non-pow2 that's the issue.

#2 800x600 isn't pow2?

#3 No it's not. Pow2 numbers can be expressed in the form 2^x where x is an integer. e.g. 2^1 = 2, 2^2 = 4, 2^3 = 8, etc.

#4 Got you. And here's what I'm seeing:

512x256 - Bad.
800x800 - Good.
512x512 - Good.

#5 This is how it looks like:

Notice how the image is not cropped, it is just shrinked in its height. I have been trying to find where it is doing this for a while now but all I am seeing is the same stuff as a identical PNG.

#6 Sigh. I'm sure it was reported to be fixed before but since it wasn't, here goes:

GFXTextureManager.cpp @ 476

_validateTexParams( dds->getHeight(), dds->getWidth(), profile, numMips, fmt );

Should be:

_validateTexParams( dds->getWidth(), dds->getHeight(), profile, numMips, fmt );

GFXTextureManager.cpp @ 497

ret->mBitmapSize.set( dds->mHeight, dds->mWidth, 0 );

Should be:

ret->mBitmapSize.set( dds->mWidth, dds->mHeight, 0 );

#7 Thank you, Stefan. Checked into repo and hopefully gone for good now.

In the process, I found two more instances where height and width got swapped.

In DDSFile, the getSurfaceSize method that takes only a miplevel has the problem (within DDSFile, height always comes first).
In the GFXTextureManager::_createTexture method you have changed above, the _createTexture calls do this as well (in TGEA, there's only one).

//Edit: Hmm, found that the swapping is necessary to get the correct pitch on texture surfaces with non-square DDSs. Too tired now to find out why.

#8 Thanks. So the getSurface method is correct? Cool!