Game Development Community

TGE1.4: guiTextEditCtrl bug&fix.

by Chris Shark · in Torque Game Engine · 11/26/2005 (11:42 am) · 27 replies

Hello
I found bug in TGE1.4 / guiTextEditCtrl .
When i click [Password] check in guiTextEditCtrl, my torque-app is suspended.

here is my fixes:

In file: gui/guiTextEditCtrl.cc proc: void GuiTextEditCtrl::drawText(...)

Ln 968:
...
   // Apply password masking (make the masking char optional perhaps?)
   if(mPasswordText)
   {
   [b]//@SHARKK:@2:earlier here--> for(U32 i = 0; i<mTextBuffer.length()-1; i++)[/b]
      for(U32 i = 0; i<mTextBuffer.length(); i++)
         textBuffer.append(StringBuffer(mPasswordMask));
   }
   else
...

Now is OK (and not suspended)!
But i still dont see "*" symbol with password-checked in texteditctrl.
and now fix:

Ln 1039:
// calculate the cursor
   if ( isFocused )
   {
      // Where in the string are we?
   [b]//@SHARKK:@2: earlier here: mTextBuffer.substring(.)....[/b]
      StringBuffer preCursor = textBuffer.substring(0, mCursorPos);
      S32 cursorOffset=0, charWidth=0;
   [b]//@SHARKK:@2: earlier here: mTextBuffer.getChar(.)....[/b]
      UTF16 tempChar = textBuffer.getChar(mCursorPos);

Ln 1125:
//draw the hilighted portion
   if ( mBlockEnd > 0 )
   {
   [b]//@SHARKK:@2: I think should have textBuffer not mTextBuffer.substring(.)....[/b]
      StringBuffer highlightBuff = textBuffer.substring(mBlockStart, mBlockEnd-mBlockStart);

Ln 1145:
//draw the portion after the highlite
   if(mBlockEnd < mTextBuffer.length())
   {
   [b]//@SHARKK:@2: I think should have textBuffer not mTextBuffer.substring(.)....[/b]
      StringBuffer finalBuff = textBuffer.substring(mBlockEnd, mTextBuffer.length() - mBlockEnd);
      FrameTemp<UTF8> finalTemp(finalBuff.length()*3 + 1);

Cya.
Chris Shark's profile picture
Torque Owner Chris Shark

About the author

no bio.

Recent Threads

NextNext Thread
PrevPrevious Thread
More from Torque Game Engine
Page«First 1 2 Next»

Associate Matt Fairfax
Night Heron Games
#21
04/27/2006 (7:13 pm)
I will see what I can do about getting a Newsletter sent out.

Torque Owner Stephen
GearedMind Studio
#22
05/08/2006 (10:44 pm)
I'm lost on how to edit the players name not showing up from the prefs.cs.

Torque Owner Chris "C2" Byars
Ion Productions
#23
06/23/2006 (9:37 am)
Caught me before I deleted the post, Stefan. No problem exists, fixes already in TLK 1.4 and TSE MS3.
|
|
V

Torque Owner Stefan Lundmark
#24
06/23/2006 (9:43 am)
What's wrong with the thread? I mean, the fixes do work. And resources are way behind in approval right now so TDN would be the best place.

Torque Owner Dreamer
Default Studio Name
#25
07/12/2006 (1:33 pm)
Hey all I have compiled all of this into a resource, you can now just search the word guiTextEditCtrl and it will send you right to the corrected version.
Regards,
Dreamer

Torque Owner Desmond Fletcher
fletcher
#26
08/01/2006 (10:48 am)
@Ben
When will this fix (#1083) become part of the installer? Your last post was january 06.

Torque Owner Duncan Gray
#27
08/01/2006 (2:36 pm)
You bought your licence, they got your money, don't expect any other commitments unless its somehow profitable to GG. They are trying to run a business you know :) Geez, the cheek of some people.

Jokes aside, perhaps we need to keep/maintain our own offsite cvs with all the fixes merged in seeing as we dont have update access to the main repository. Unless GG have another solution in the pipeline which we don't know of yet.
Page«First 1 2 Next»