Particle engine crashes when removing emitters

First of all: i'm using torque 1.2.


The full patch can be found here:
www.garagegames.com/index.php?sec=mg&mod=resource&page=view&qid=4899


---


Note: this patch requires the improved particle emitters patch
You can find it here..
www.garagegames.com/index.php?sec=mg&mod=resource&page=view&qid=4096


I see that particle engine crashes, at end of mission (when removing all emitternodes/emitters).

The problem is that while removing the emitternode/emitter, the advanceTime method gets invoked (code is not thread-safe?) and tries to work with the currently destructed emitter/emitternode.

This is a problem, when the machine is slow, and advancetime is called with a greater probability while destructing.

I've fixed one bug with in particleemitter.cc, adding:

void ParticleEmitterNode::onRemove()
{
   removeFromScene();
   if (isClientObject()) {
      mEmitter->LinkObject = NULL;	// fixed by robymus: shutdown hanging
      mEmitter->deleteWhenEmpty();
      mEmitter = NULL;
   }

   Parent::onRemove();
}

it was a big problem, emitternode is destructed first, then the emitter referenced the destructed node.

but it still has problems:

destructed particles are accessed from PEngine (which is invoced from ParticleEmitter::advanceTime)..

i think advanceTime and onRemove should be made mutually exclusive.

if you have a better idea for this, or a ready-to-go patch, i will appreciate it :)

If not, tomorrow i will patch it and post a resource on it..

Please help me :)