Game Development Community

iPhoneStreamSource.cc memory overwrite and leak in iTGB 1.2

by Gregg Patton · in iTorque 2D · 08/23/2009 (6:29 pm) · 5 replies

Howdy,

Please correct me if I'm wrong...

In the constructor:

iPhoneStreamSource::iPhoneStreamSource(const char *filename) {
this->registerObject();
int len = dStrlen( filename ); <<< this will return the length of the string without the NULL terminator.
mFilename = new char[len]; <<< this will be one character too short.
dStrcpy( mFilename, filename ); <<< this will overwrite memory.
}

mFilename = new char[len + 1]; seems to fix it.

Also, mFilename doesn't appear to get deleted anywhere. I started deleting it in the destructor.

I was getting all sorts of weird behavior after I would load 3 or 4 MP3 files. Changing to "new char[len +1]" made everything a lot happier.
NextNext Thread
PrevPrevious Thread
More from iTorque 2D


Torque 3D Owner Ronny Bangsund
Torque Cheerleaders
#1
08/24/2009 (2:49 am)
Yeesh, horrid! Thanks for noticing that :)

Torque Owner BeyondtheTech
#2
08/24/2009 (7:29 pm)
For those not Objective-C savvy, can you post the code changes regarding "deleting it in the destructor"?

Thanks.

Torque Owner Gregg Patton
#3
08/24/2009 (8:28 pm)
Here's the destructor.

iPhoneStreamSource::~iPhoneStreamSource() {
    stop();
    delete [] mFilename;
}

Associate Dave Calabrese
Cerulean Games
#4
08/25/2009 (2:36 am)
Going to roll this change into my local project - Excellent catch!

Torque Owner Damir Slogar
Default Studio Name
#5
08/26/2009 (2:18 pm)
also in Teardown() change 

if (mPacketDescs)
			   delete mPacketDescs;

to

if (mPacketDescs)
			{
				delete [] mPacketDescs;
				mPacketDescs = NULL;
			}